Marc Durdin

Results 376 comments of Marc Durdin

> Alas, this might be too complicated to get into 16.0 at this point :/ We've bumped this for 14 and 15, so I think we need to look at...

I've run through and tested this. I encountered no breaking issues. The new style is very clean; I like it. Some of the things I've noted here are probably not...

Going ahead and merging so we can launch beta. We will need to do another round of usability review during beta, but I expect any changes would be minor and...

> * TEST_DENY_ACCESS_AND_RESTART @sgschantz, I think we should reorganise these tests [using groups](https://github.com/keymanapp/keyman/wiki/User-Testing-Workflows#test-suites-and-groups) for the test bot. GROUP_CATALINA: Using a version of macOS 10.15 or later GROUP_PRE_CATALINA: Using a version...

> The behaviors on the right alt and right alt+shift are extra observation while testing with Khmer Angkor with those layers utilized. I see. Can you call those out as...

Given our current discussions, I hope you don't mind if I return this to draft to take it out of the review queue temporarily?

The files and folders permission will probably be required when you install a keyboard, yes?

@DavidLRowe this fixes the icon loading crash :grin:

> * Adding the valid icon file (which is attached to this test) leads to crash the Keyman developer. Thank you @bharanidharanj, I will investigate! If you experience crashes in...

@bharanidharanj thank you for the tests; I have fixed the issue you experienced; can you retest please? @keymanapp-test-bot retest