keyman icon indicating copy to clipboard operation
keyman copied to clipboard

chore(android/engine): Remove use of lexical-model catalog

Open darcywong00 opened this issue 4 years ago • 8 comments

This a change from 13.0 to 14.0 where we no longer need to cache the catalog info of available lexical-models e.g. https://api.keyman.com/model?q

During keyboard installation, a check is already made for the associated lexical model and that gets downloaded/installed as needed.

TODO

  • [x] Remove queries for the catalog info
  • [ ] Add a one-time upgrade check going to 14.0 for existing keyboards and installing associated lexical-models (this is a stretch goal, and likely to defer to future release).
  • [ ] Cleanup data/Dataset
  • [ ] Change ModelPicker UX
    • [x] Open Dictionaries option, Keyman should query api.keyman.com for available models for that language.
    • [ ] Show spinner in dictionary list until it finishes loading

@mcdurdin can you provide guidance on impacted UX?

  1. in "Settings" --> "Languages", there's existing workflow where users can navigate to "Dictionaries" and pick an available model to install (if not installed yet)
  2. I believe we will still allow users to navigate to an installed model and display the model info screen

darcywong00 avatar Oct 28 '20 04:10 darcywong00

  1. in "Settings" --> "Languages", there's existing workflow where users can navigate to "Dictionaries" and pick an available model to install (if not installed yet)

When they open the Dictionaries option, Keyman should query api.keyman.com for available models for that language. That can be a synchronous action -- they have to wait for the query to complete to list the available models (or they can click Back to cancel the query). Cleanest way to do this is to show a spinner in the dictionary list until it finishes loading.

If offline, it will show just the installed dictionaries.

2. I believe we will still allow users to navigate to an installed model and display the model info screen

Yes.

mcdurdin avatar Oct 28 '20 19:10 mcdurdin

Too late for 14.0 so this will push to 15.0

darcywong00 avatar Mar 19 '21 00:03 darcywong00

Technical debt we'll try to do as a stretch-goal late in 15.0

darcywong00 avatar May 10 '21 00:05 darcywong00

Too much technical debt to get into 15.0 so deferring to 16.0

darcywong00 avatar Nov 15 '21 04:11 darcywong00

Alas, this might be too complicated to get into 16.0 at this point :/

darcywong00 avatar Oct 03 '22 02:10 darcywong00

Alas, this might be too complicated to get into 16.0 at this point :/

We've bumped this for 14 and 15, so I think we need to look at this for 16. Happy to rubber ducky with you next week?

mcdurdin avatar Oct 06 '22 07:10 mcdurdin

Happy to rubber ducky with you next week?

I'll be out that week, but can rubber ducky A16S13

darcywong00 avatar Oct 06 '22 07:10 darcywong00

Sadly bumped again due to work on longpress menus which was higher priority.

mcdurdin avatar Oct 11 '23 01:10 mcdurdin