Mario Casquero

Results 182 comments of Mario Casquero

Could this patch be merged? Thanks !

> copying the tool pack @MiriamDeng the fail message is from the previous patch version, now there's no such message when copying the tool. Could you ensure that you have...

@luckyh @yanan-fu @YongxueHong please, could you review this PR? Thanks !

> Hi @mcasquer I got your purpose, there is just one concern that it may affect the related test case which is calling the previous path, for example, https://github.com/autotest/tp-qemu/blob/539f0cb578680f344610b18487ba511e2ecd6897/generic/tests/trans_hugepage_defrag.py#L67C8-L67C73 >...

> The provider script be removed with the latest update ? It is being moved to the root deps directory in order to be used by the #3988 script

@YongxueHong could you review again this PR? Thanks!

According to the @PaulYuuu comment in https://github.com/autotest/tp-qemu/pull/3988#discussion_r1546236850 I agree that it's feasible to store directly the C script file

@PaulYuuu @yanan-fu @YongxueHong could you review this PR again? Thanks!

> @PaulYuuu @yanan-fu @YongxueHong could you review this PR again? Thanks! Keep in mind that difference with the last change has been only the file extraction, the C code is...

It seems when doing the extraction I missed the v2 tool, updating again...