Matt Casper comments

Results 18 comments of


                                            Matt Casper

Possible Feature: `:ToggleDebuggers`

I think my stance on this one is going to be: If most people want this (which not many people use this, so it wouldn't be hard) I'll accept a...

Ignoreable

Hey @j-mcnally, thanks for the contribution. I'm curious what a real world scenario would look like for this option, as in most cases I would think you'd either want to...

escape error class and error message on failure show page

Hey @jcope2013, thank you very much for the contribution, this looks great. Can you just merge master into your branch to make sure tests pass? After that this should be...

Add 1 to retry_count To Properly Report Exhausted Failures

Hey @mstruve, thanks for the contribution! It looks like this is likely only a bug in sidekiq 5+, when they moved all internal middleware out of the middleware chain. In...

Update code and fix for new versions

Hey @alisonjenkins, thanks so much for doing all this work to modernize the project! The Rust parts look great! Could you drop the Nix specific files from the changes, or...

Window build fails

Thanks for reporting @BigKahunaCanuck, I unfortunately don't have a windows machine to try this out on, but would be happy to accept a PR!

Window build fails

@rschmitt I'm good with option 1, a PR would be wonderful!

Not working with sidekiq 8

Good point! This should be resolved now