git-clean icon indicating copy to clipboard operation
git-clean copied to clipboard

Update code and fix for new versions

Open alisonjenkins opened this issue 1 year ago • 2 comments

  • Updates the cargo dependencies and adjusts the code to work with the new version of clap.
  • Sets the Rust edition and adjusts the code as appropriately.
  • Fixes all clippy lints that were found on the code.
  • Tests all pass.

alisonjenkins avatar Oct 28 '24 10:10 alisonjenkins

Hey @alisonjenkins, thanks so much for doing all this work to modernize the project! The Rust parts look great!

Could you drop the Nix specific files from the changes, or add them to the gitignore? After that I think this should be good to merge

mcasper avatar Oct 29 '24 13:10 mcasper

Hey @alisonjenkins, thanks so much for doing all this work to modernize the project! The Rust parts look great!

Could you drop the Nix specific files from the changes, or add them to the gitignore? After that I think this should be good to merge

Are you sure you want to get rid of them? They are basically packaging the project for Nix and providing a devshell that enables anyone using Nix to basically just run nix develop and be setup to be able to build and develop the project.

alisonjenkins avatar Oct 29 '24 16:10 alisonjenkins