Michael Abbott

Is this the obvious definition? I would have guessed that it was this: ```julia mod(z::Complex, n::Real) = Complex(mod(real(z), n), imag(z)) ``` That is, perform one identification on the complex plane,...

Sure, I can try. Ordinary trig functions are periodic on the real line, e.g. `tand(5) == tand(5 + 180) == tand(5 + 2*180)`, and this fact is captured by `mod(5,...

I didn't think to look, but here's what Mathematica does: ```mathematica Mod[5+I,10] Mod[6+I,10] (* real output in -5 to 5, although Mod[6, 10] == 6 *) Mod[15+I,10] Mod[16+I,10] Out[175]= 5+I...

Here's another argument: `x ≡ y (mod z)` means that, for some integer `n`, we have `x = y + n * z`. The function is `mod` is supposed to...

@stevengj I still think it should be `mod(z::Complex, n::Real) = Complex(mod(real(z), n), imag(z))` for this case. I've tried to argue various ways above. The proposed behaviour seems right for a...

I would say the relevant meaning of "inverse" would be this, which is close but not quite right: ```julia julia> inv(floatmax(Float32)) 2.938736f-39 julia> floatmin(Float32) 1.1754944f-38 julia> nextfloat(0f0) 1.0f-45 ``` If...

`isgreater` takes two arguments. I presume "inverse" there means you reverse them. That may not be an ideal word but it is clarified extensively just below. And is irrelevant to...

>> Return the smallest finite number representable by the floating-point type T. > But it doesn't But it does! Here "smallest" means smallest in absolute value, large negative numbers are...

Haven't run this, but sometimes Zygote is confused by re-using the name `prob`. Does it happen with e.g. `prob2 = remake(prob, p=ps)`?

Without solving where these come from, they should both probably be `nothing`. You could try asking `_project` to standardise for you: ``` julia> methods(Zygote._project) # 2 methods for generic function...