Michael Abbott
Michael Abbott
That's bad, sorry. What should it do? It can't push its guess into the existing array, since `convert(String, 3)` is an error. It can't save `vcat(A.index, 3)` into the original...
Surely this can be made to infer. The trick `if length(axes(dx)) == length(project.axes)` is clever, but what I think it will miss is that the reshape at present restores OffsetArrays,...
[Edited!] The simplest effect is like so, although right now this works only if it accepts `Tangent{Any}`: ```julia julia> Zygote.gradient(x -> parent(x)[1], Diagonal([1,2,3]))[1] 3×3 Diagonal{Float64, Vector{Float64}}: 1.0 ⋅ ⋅ ⋅...
Spotted today, this is an example in the wild of what this PR wants to do: https://github.com/SciML/DiffEqFlux.jl/blob/61cc51e1b63709d55655c53d50244cc3932bd60e/src/DiffEqFlux.jl#L71-L73 That's for Tridiagonal. Notice that it always has to make two zero Vectors...
OK I think this is done. Plays well with Zygote 6.30: ```julia julia> gradient(x -> sqrt(sum((x .^ 2).ev)), Bidiagonal([1,2,3], [4,5], :U))[1] 3×3 Bidiagonal{Float64, Vector{Float64}}: 0.0 0.624695 ⋅ ⋅ 0.0 0.780869...
Bump? This is one of the last pieces of the ProjectTo story worked out last summer, but somehow hasn't made it. We'd have heard if its absence was holding anyone...
That looks like a bug, indeed. I think there ought to be a method `Base.dotview(A::KaNda; kw...)` which looks up the names.
I get the same error on latest Yota + Umlat. The rule for `convert` silences the error, but doesn't actually make the `struct` requested. It isn't used above, but if...
It's not impossible there are bugs in `_rebuild`, sorry, it's pretty messy. Will take a look, at some point. Trying to find a simpler example of what I thought was...