Michael Abbott

Would be good for docs to note that not every AbstractArray of Numbers is a leaf, e.g. Transpose

Can this update the readme too? I think that (besides deleting `@functor Foo`) it wants a big notice that [email protected] is sort-of opt-out now, defaults to calling ConstructionBase.

Is `structure(x)` going to be confusing next to `destructure` which isn't the opposite? Other words... `plain` or `simple` etc?

What I don't like about `fmapstructure` as a name (in any form) is that the "`struct`ures" are precisely what it does *not* preserve. It preserves the graph of children, it...

There has got to be a nice name somewhere. They aren't strictly trees due to cache. "simple" or "strip" or "raw"... It's basically a recursive application of `children`, does that...

Any chance that https://github.com/JuliaDiff/ForwardDiff.jl/pull/669 solves this?

Seems like a lot of code. I reproduced the above benchmark here: https://gist.github.com/mcabbott/fe2e0821e9bfe5cc7643bb15adf445d0 I get 75.625 μs for `first(Iterators.drop(itr, n-1))` vs 1.558 μs for the PR. However, this is entirely...

Is there any precedent for a `nothrow` keyword? We could also follow `get(A, key, default)`, as you suggested earlier. It seems [edit: in this case!] a little confusing that this...

The 5th option is Union{T,S} where you supply S -- like `get`. That, 2 (error, like `getindex`) and 4 (Some/Nothing) are the competitors. > What is the semantic difference between...

I presume the point of `nth(iter, [3, 17, 245])` vs. broadcasting `nth.(Ref(iter), [3, 17, 245])` is that it would run the iterator only once. How well `nth` fits with the...