Marc Bernard

Currently, pulling `TABU` entries shows a corresponding `TABU ` entry in the pull confirmation popup. Requirement: Add a page to show a detailed preview of data changes. There could be...

Refactoring: Prioritization of deserialization

2

The order objects for deserialization is currently defined in ZCL_ABAPGIT_OBJECTS->PRIORITIZE_DESER and must be changed in case of new object dependencies. Refactor so each object type can define itself, which other...

Refactoring: CSS for Themes

2

The theme css files are full of different color codes. Surprising that the default look of abapGit is relatively consistent. However, it's really not especially in dark mode. Creating a...

ABAP Logger v2

23

Collecting breaking changes for an eventual v2.0.0 1. Remove `new` and `open` methods from `zcl_logger` (replaced be `zcl_logger_factory`) 2. Remove aliases from `zcl_logger` (not necessary if you use factory which...

If there are just warnings, shouldn't the exit code be 0? https://github.com/Marc-Bernard-Tools/Mirror-LOGGER/actions/runs/7242477691/job/19727970912

There are a lot of `unnecessary_return` messages related to something like this: ```abap METHOD zif_abapgit_background~get_settings. RETURN. ENDMETHOD. ``` ```jsonc "unnecessary_return": true, "method_length": true, // "errorWhenEmpty": true is the default ```...

select_add_order_by: cannot use `order by` with `for all entries`

4

There are cases where it's not possible to add `order by`:  ```abap SELECT progname FROM reposrc INTO TABLE lt_reposrc FOR ALL ENTRIES IN rt_includes WHERE progname = rt_includes-table_line AND...

https://help.sap.com/doc/abapdocu_756_index_htm/7.56/en-US/index.htm?file=abenuse_operand_position_guidl.htm could be an option for the `sy_modification` rule

https://help.sap.com/doc/abapdocu_756_index_htm/7.56/en-US/index.htm?file=abenfunction_modules_obsolete.htm rule name could be 'function_module_parameters' - check if function modules are using `TABLES` parameter - check if parameters are defined using `LIKE` - check if global parameters are used

Solution works on Exercism, but gives syntax errors in ABAP. For example, the following solution should not be valid: https://exercism.org/tracks/abap/exercises/collatz-conjecture/solutions/phrexx91  Unless the parameter is passed by value, it can't...