Marc Bernard

classic_exceptions_overlap: Enumerate all exceptions

3

This one cost me hours of additional debugging and modifying SAP code to figure out what the actual return code was: Bad examples: ```abap CALL FUNCTION 'TR_TADIR_INTERFACE' EXPORTING wi_tadir_pgmid =...

except syntax error for "into table"

2

```abap REPORT zfoobar. DATA str TYPE string. DATA int_tab TYPE TABLE OF i. str = '1 2 10'. SPLIT str AT ` ` INTO TABLE int_tab. " only tables with...

indentation: quickfix adjusts only first line of statement

1

```abap REPORT zfoobar. cl_abap_unit_assert=>assert_equals( exp = '1' act = 1 ). ``` /zfoobar.prog.abap[2, 3]: Indentation problem, expected 0 spaces(indentation) Quickfix will correctly change line 2 to 0 indent but will...

prefer_inline: false positive when using interface/class?

2

When using global interface and class, it says to use inline declaration. Is there a way to do this in ABAP and avoid the error? https://github.com/mbtools/TEST_INLINE/runs/3920601749  Program `ZTEST_INLINE_GLOBAL`: ```abap...

call_transaction_authority_check: false positive

5

false positive in case auth check is done via function module ;-) ```abap CALL FUNCTION 'AUTHORITY_CHECK_TCODE' EXPORTING tcode = lv_tcode EXCEPTIONS ok = 0 not_ok = 2 OTHERS = 3....

unused_ddic/modify_only_own_db_tables: Dynamic references

1

Consider the following: ```abap REPORT zfoobar. CONSTANTS c_tabname TYPE tabname VALUE 'ZTESTTAB'. DELETE FROM (c_tabname) WHERE test = 'NO'. ``` If a DDIC object is not statically referenced, it's quite...

check_subrc: False positive when after else/endif

4

/zfoobar.prog.abap[4, 3]: Check sy-subrc(check_subrc) ```abap REPORT zfoobar. DATA ls_t100 TYPE t100. IF 1 = 1. UPDATE t100 FROM @ls_t100. "

I appreciate the tests included with the repo. I'm porting the solution to another language. My port was not working when the input data had empty lines. I noticed that...

REGEX

5

ABAP regex is different from PCRE. However, it looks to me that the transpiler uses PCRE regex. ABAP Example (from Phone Number exercise, which works without errors in ABAP but...

Error with FIND IN TABLE, line

8

Find in string works, but find in table gives error ```abap TYPES: BEGIN OF ty_submatch, offset TYPE i, length TYPE i, END OF ty_submatch. TYPES: BEGIN OF ty_match, line TYPE...