Matt Browne

Results 89 comments of Matt Browne

In case it helps, for this use case at least it wouldn't be necessary to replace the method (although maybe that would be most straightforward)...turning it into a regular private...

Of course, if you want to use private fields and methods, there's always this workaround—technically a private field (arrow function) rather than a private method: ```js class ComponentWithPrivateMembers { #x...

@mhofman > I'm wondering if allowing the accessor modifier on private methods would make sense? I think it could be a bit weird to expand the concept of "accessor" to...

@biro456 Thanks, it's nice to know this is possible. I'm not sure if the `this: T` part in the function you're returning is necessary unless you found that something didn't...

Aww ok, I hadn't inspected it closely yet but that makes sense. I believe the `bound` function only runs once.

I have a question that's somewhat related to this so I thought I'd start by posting a comment here. Reading the current proposal, it's currently unclear to me whether it...

Here's an example of an implementation that's currently doesn't work due to the ignored properties: class Entity { assignAttributes(attributes) { for (let key in attributes) { if (key in this)...

I created a repo earlier with a reproduction of this issue. Steps to reproduce: ``` git clone [email protected]:mbrowne/graphql-mesh-bug-repro.git --single-branch --branch grpc-source-issue cd graphql-mesh-bug-repro yarn yarn grpc:start ``` Then in another...

@michaelmohamed Unfortunately it's not that simple... TLDR if you just want to get it working, then I recommend downgrading to an older version of the grpc handler for now; I...

Sorry @rdking, that must have been a bad recollection on my part. I removed that from the original post.