Matt Browne

Results 89 comments of Matt Browne

Glad to hear you got it working! `babel-plugin-pure-static-props` shouldn't be needed if you're already using the forked plugin based on this PR. If it doesn't work anymore after removing `babel-plugin-pure-static-props`,...

Ah, sorry I missed that...does my latest commit work? It's not checking for the case where no format is passed, but that already has its own deprecation message (`undefined format:...

I think my latest changes should work? Can this be merged? Thank you

It shows the deprecation warning if you do: `morgan('default')`, which I thought was the standard way of doing it. If `morgan.default` still needs to work, then unfortunately that defeats the...

Actually I just thought of a solution that I think preserves the current behavior...in my initial testing it seems to work fine. It's a change to the exports at the...

> We then see that we're setting the __esModule property of exports to true. This simply tells any system that imports this file that it just imported a module. If...

P.S. The `__esModule` property is automatically set to true by Babel and other tools when they're transpiling ES6 modules to CommonJS modules. So if you intend to use `import/export` syntax...

After further investigation, I found that my proposed solution doesn't work the way I thought it would. (I think the only way that would work correctly is if it were...

Originally I didn't think it was an esm bug, but after looking into this I'm wondering if maybe it is...maybe it wouldn't happen if esm checked for that `__esModule` flag....

Looks like someone reported this same issue in the esm repo: https://github.com/standard-things/esm/issues/812