Matt
Matt
For later then
A couple of usability/accessibility issues: - No keyboard focus indicator - It isn't possible to escape from the editor with the keyboard; focus is trapped. Tab inserts tabs, Esc does...
I'm definitely not seeing a keyboard focus indicator (highlighted border). You're right, Esc does work, but it doesn't always return focus to the correct place. (It returns to the top...
> I noticed that the focus indicator is hardly noticeable in light mode There's no keyboard focus indicator in dark mode either. It's the same whether focused with keyboard or...
@nihgwu I can tab to it, but then I can't edit the content. "pls check again" 😁 "Tab through" works, so that's progress, possibly... tab-through when it isn't possible to...
> if you read the last commit I don't think most users would come and read the commit. 😁 The hint helps. Perhaps it should use `aria-live`? > if you...
> Sorry I mean reviewers The point being that, as implemented, the behaviour was not intuitive. If the only way to understand what's happening is to review the code, something's...
> why the first Enter should be swallowed Agree, it would perhaps be better if it both captures focus _and_ starts editing the text. I had only tried typing to...
Making progress! The keyboard focus indicator (blue outline) is now present both when hovering over the editor and when it's selected, which is a step backwards since https://github.com/mui/material-ui/pull/32107#issuecomment-1092173585. It should...
The docs don't use the default Material UI theme.