Mathieu Brédif

Results 32 comments of Mathieu Brédif

I agree that examples should be simplified (removing the video from webgl_lights_spotlight and leaving webgl_shadowmap_viewer untouched). They were there only to show/test the PR.

@usefulthink @Mugen87 , I just rebased this PR !

That is a matter of taste * `mix( directLight.color, spotLight.color * spotColor.rgb, spotColor.a )` is how it is implemented : the spot texture alpha mixes the cone of penumbra and...

I gave a try in #24539 to enable the use of spotlight textures with and without the cone of light effect. Let's switch the discussion there :)

What about this version ? https://github.com/mbredif/three.js/blob/copyTextureToTexture_merged/src/renderers/WebGLRenderer.js#L2083-L2227 . As @DavidPeicho mentioned, the 2 copy functions could be merged to factor common code. I also removed the box shrinking code to simplify...

Feel free to simplify things, but please keep something that is extensible by design ! (support custom layers with custom properties, custom sharders...)

On a related topic, I have added message and point subsampling options to PointCloud2 and LaserScan and optimized it somehow in #218. A new example (examples/kitti.html) shows that subsampling helps...

I confirm that these are legacy transforms to enforce undocumented frame conventions for Stereopolis datasets. I agree that these "convention matrixes" should go to the json metadata files to streamline...

here are the currently working demos: http://itowns.github.io/itowns-sample-data-small/ : low res images http://itowns.github.io/itowns-sample-data : high res images, 3Dbuildings, point-cloud http://itowns.github.io/v1demo.html : low res images, 3Dbuildings, point-cloud

I have just put a more informative title. could you please provide some info on the incompatibility (error message, console log, https://get.webgl.org/ status...)