Marc Brinkmann

Rocket 0.5.0-rc.1 support

2

This supersedes #258 and depends on the `v0.5.0-rc.1` tag of rocket, also contains the latest `main` branch changes, resulting in a pleasantly small diff. As rocket 0.5 is still unreleased,...

Custom baud rate

7

This pull request contains code that allows setting custom bit rates on Linux, which is very useful for handling strange or proprietary protocols. For this to work, first https://github.com/dcuddeback/termios-rs/pull/8 needs...

API for allowing different timings for settings-changes to take effect

1

Currently, settings (on Linux) are changed using `tcsetattr` in `write_settings`, passing in `TCSANOW` for `optional_actions`. This causes the new settings to take effect immediately, here's the code in question: ```rust...

Examine `Broadcast` for optimization potential.

31

While debugging an issue with failing tests, I encountered some inefficiency in the reliable broadcast algorithm, at least inside the edge-case of a two node network. Consider the following partial...

Clear up confusion by introducing definitions in hbbft

13

There has been a bit of confusion between observers, nodes, validators and some other terminology, especially since it is not 100% clearly defined. Our main issues occur on the boundary...

Improve Logging

4

When running tests to track down bugs or in production, it would be very beneficial to collect traces, networking logs or simple status messages for analysis. Currently, there is a...

Code coverage

3

Inspired by @DrPeterVanNostrand's potential bug due to a never-taken branch, I gave coverage a try. Other crates are using some form of coverage (e.g. https://github.com/ctz/rustls does not only feature an...

License?

1

Hey Aahan, what license is the github.css file under? Is that a part extracted from the actual github code or a reimplementation? If so, could you license it, so it...

Fix should be self-explaining.

I've ran into the following issue triggering an assert in https://github.com/poanetwork/hydrabadger/blob/db28cadbfac3f6390e33d130144db3f00f3fd4a0/src/hydrabadger/handler.rs#L763 in version db28cad (which is currently pinned using `Cargo.lock`): ``` ==================== stack backtrace: 0: 0x56385a51c76c - backtrace::backtrace::trace::hd87abb16dd370d7a 1: 0x56385a51b9e2...