nfsen-ng icon indicating copy to clipboard operation
nfsen-ng copied to clipboard

Using composer for dependencies

Open mbolli opened this issue 2 years ago • 3 comments

Thinking about adding some dev tools to ensure code quality, and maybe add some tests. This would also enable the project to fetch the only 3rd party dependency there is (the CLI progress bar) via composer. Although I might have to produce my own fork of the project, as there have been some fixes which are not in the original repo.

Any thoughts for/against this?

mbolli avatar Apr 14 '22 09:04 mbolli

Although I might have to produce my own fork of the project, as there have been some fixes which are not in the original repo.

Any thoughts for/against this?

Vendoring is considered to be a bad idea security-wise.

xtaran avatar Apr 14 '22 09:04 xtaran

That's true and why I'm opening this issue as well. In this case though, the original repo hasn't received any changes since 9 years. So it just is not according to best practices, but security-wise does not matter.

mbolli avatar Apr 14 '22 09:04 mbolli

Ok, yeah, 9 years is a long time indeed.

xtaran avatar Apr 14 '22 10:04 xtaran

Composer autoloading is introduced in #90

mbolli avatar Jan 10 '24 21:01 mbolli