Markus Schirp

Results 299 comments of Markus Schirp

@moonglum Did you tried `Adamantium::Flat` already? Its a really nice alternative in case deep freezing might reach into non freezable objects, or you care about the perf implications. Its implementation...

@moonglum no. Instances of Anima infected classes are not frozen by default. You can if you wanted via including `Adamantium` or `Adamantium::Flat` next to `Anima.new(:my, :attribute)`.

I like this change. We have to communicate methods need to be present / changed before `Adamantium` is included. Especially in conjunction with `Equalizer`. Correct: ``` ruby class Foo include...

I just remember a chat conversation in `#jruby`, we improved performance on rack hashes with using separate String subclasses for keys that freezed contents and caches`Object#hash` I lost the gist...

@dkubb I perform this normally via some shell + vim batch editing. Not too much automated.

I think the better way forward is to simply implement the thread save cache based on ruby core provided primitives. Rather than pulling another big dependency in for dropping one.

@ivoanjo This argument is good but does not beat having no dependency at all.

@ivoanjo Its not my final call, its not my gem. Once my clients reach 2.4 (they are not because I'm very defensive until it stabilizes) I'll hit the problem by...

> It would be a good idea to remove the dependency from axiom-types. Or add an explicit dependency on `rspec-its`.

@troessner I think there was a reason to use the object ids, but we'll have to wait for @dkubb to find the time to answer this.