Markus Schirp

Results 299 comments of Markus Schirp

Its very likely this is solved by #366, will test it. Sadly #366 is not ready yet as its a deeper refactor.

Fixed with #366 which just got merged.

@akimd Also released as 0.7.0. This was as significant blob of work. And more work is to come to support 3.4 correctly as `parser` is being deprecated in favor of...

> @mbj do you want help adding a test for this? I'm to busy ATM to get back to that sorry. I do not need help, I need time ;)...

> That test looks good, can @mbj confirm that's the expected error message they see with their corrupted files? Thanks both of you for the contributions! I think its good...

Interesting, whitequark/parser seems to accept it right now, producing this AST, its accepted in 2.7, 3.0, 3.1 and 3.2 here. ``` (case-match (send nil :foo) (in-pattern (hash-pattern (pair (dsym (begin...

For full visibility, I've reported this in: https://github.com/whitequark/parser/issues/919. I do not want to filter it out unparser side for the moment. I'll do so with a fixing `parser` release.

@kddnewton if you are importing unparsers tests, you can just ignore this pattern, or would it be better for you I pushed a removal?

Well I'd be happy to use YARP in the future as source AST for unparser. So thanks to you. I hope you made dstrings less ambigious in your native AST,...

@kddnewton yes helps me already, the story goes a bit deeper. I'll reply here later explaining it.