Matthieu Bilbille

Results 10 comments of Matthieu Bilbille

Facing the same limitation... Wrapping pairs of `if` and `then` inside an `allOf` does not seem to be supported in the latest 1.25-beta version. And I did not find any...

Thanks @tungxen for bringing this. Support for some extended katakana forms is missing (https://en.wikipedia.org/wiki/Hepburn_romanization#Extended_katakana).

Thanks to @Akeru's work PR #47, we've a working version of the Converter component to release on 0.6 :) On 0.7 we should complete this component with reverse number conversion...

Nice, we can include that within the 0.6! Thanks @Akeru

Will try to spare some time to rearrange `Converter.php` into smaller files (.php and .yml files) as we did with `Transliterator.php`

Btw unit tests are broken on a 32-bit system. `````` bash 1) JpnForPhp\Tests\Converter\ConverterTest::testConversionToJapaneseNumeral1050919092985 Undefined offset: 0 E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:467 E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:450 E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:455 E:\tmp\jpnforphp\tests\JpnForPhp\Converter\ConverterTest.php:82 E:\bin\xampp\php\pear\PHPUnit\TextUI\Command.php:176 E:\bin\xampp\php\pear\PHPUnit\TextUI\Command.php:129 2) JpnForPhp\Tests\Converter\ConverterTest::testConversionToJapaneseNumeral10100100100101 Undefined offset: 0 E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:467 E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:450 E:\tmp\jpnforphp\src\JpnForPhp\Converter\Converter.php:455...

Yes that was my understanding too. > JpnForPhp\Tests\Converter\ConverterTest::testConversionToWesternYearKanjiMeiji33 Didn't have time to investigate further, don't know this one on date conversion fails for the same reason.

Fixed above issues with : 3ddfc860539001b264392babe37c7dad7fe4c1c1 3dcbee899b0d608e0f592023edf7bf53812fd3e6 7b943f9d71662b2cccd8e4e1131a380a4fae33ab

4 months to open this issue... sorry about that I gave a look to the group format, what about kanji like 頑 which have sub-parts inside of their parts? I...