Michael Best

Results 149 comments of Michael Best

Thanks for the suggestion. Is there a precedent for this syntax?

I like the `_someProperty` idea, although it could be made even more obvious with `somePropertyObservable`. It seems this might also eliminate the WeakMap dependency.

Are you sure there are observable objects within the array?

The answer is that array items are not made observable, even when the `deep` option is used.

Isn't that already done [here](https://github.com/SteveSanderson/knockout-es5/blob/master/src/knockout-es5.js#L104)?

Sorry. It looks like when using `ko.track` that functions aren't converted to `ko.computed`, but to a regular `ko.observable`.

According to http://blog.stevensanderson.com/2013/05/20/knockout-es5-a-plugin-to-simplify-your-syntax/, functions are supposed to be left alone, but since they aren't, this change seems like a good one. I'm not a maintainer here, but just commenting.

When initializing a model with arrays, it also doesn't accept read-only arrays. Is that because the array instance is reused?

This was fixed in TypeScript: https://github.com/microsoft/TypeScript/pull/48380

JSS looks cool. Related: knockout/knockout#1692