tko icon indicating copy to clipboard operation
tko copied to clipboard

Support JSS for styles

Open brianmhunt opened this issue 6 years ago • 3 comments

With JSX (#25) and jss we should be able to fully compartmentalize the code for components.

I'm hoping to get this in for Beta-1, since once we're done catching TKO up to the mainline branch, this is relatively low hanging fruit.

Thoughts @knockout/core @knockout/extended ?

brianmhunt avatar Jun 14 '18 14:06 brianmhunt

JSS looks cool. Related: knockout/knockout#1692

mbest avatar Jun 15 '18 10:06 mbest

JSS supports TC39 (#22) observables, so I'd argue to properly get jss support we'd want TC39. Experimenting now.

brianmhunt avatar Jun 21 '18 10:06 brianmhunt

If this is still a stumbling block, you could consider going with Constructable Style Sheets instead of JSS. They are live in Chrome, and Jason Miller made an attempt at a tiny polyfill, which appeared to work in FF and Safari when I tried it.

Followup: So, it turns out that, while replaceSync() worked as expected, I got weird errors about illegal characters when trying to use replace() with the polyfill.

avickers avatar Jun 25 '19 05:06 avickers