Mauro Berlanda

Results 21 comments of Mauro Berlanda

hi @fredwillmore , it looks like the behaviour you are describing is covered by unit tests https://github.com/jamis/bulk_insert/blob/master/test/bulk_insert_test.rb . Can you confirm you can reproduce it consistently?

@jamis do you remember why you choose to return `nil` when implementing this feature here? https://github.com/jamis/bulk_insert/commit/95a0c43a09e745dc7f79bd766336890ca86a19bb

Hi @ShiraUnger could you provide more context on the problem you are facing? (e.g. ruby version, active record version, gem version). It would be great to have as well a...

It should be fine for postgresql I guess. For MySQL is a little bit more complicated since you cannot emulate the behavior of postgresql's `returning` out of the box: Returning...

I have checked the current implementation of `exec_query` for MySQL adapter on the ActiveRecord master branch: https://github.com/rails/rails/blob/master/activerecord/lib/active_record/connection_adapters/mysql/database_statements.rb ```ruby def exec_query(sql, name = "SQL", binds = [], prepare: false) if without_prepared_statement?(binds)...

ok! Don't worry! I hope I will have the time to finish soon #37 to allow testing against the real database without mocking the adapter. In this case we should...

I would wait for @jamis feedback before merging. I was considering to go for a major bump dropping the support for ruby < 2.4 and rails < 5. This should...

@aqeelvn I hope you are doing great! Would you be available to re-submit your changes in a new revision of this PR rebasing on master? I managed to make the...

hey @aqeelvn do you want me to cherry-pick your changes and adapt them to the new gem structure?

Hi @harto , thank you very much for raising his issue. Would you be able to short snippet to reproduce the issue? If you can write a unit test and...