Michael Beardsworth
Michael Beardsworth
Friendly ping @caguero
> By making `Discovery::AddRelayAddress()` public, I think we now have risk for potential race conditions, as `this->relayAddrs` can be modified from a user thread (via `Node`) and the discovery thread...
> > > By making `Discovery::AddRelayAddress()` public, I think we now have risk for potential race conditions, as `this->relayAddrs` can be modified from a user thread (via `Node`) and the...
Thoughts on this test failure https://build.osrfoundation.org/job/gz_transport-pr-win/99/ ? I'm having a hard time figuring out how this PR would trigger behavior change on those tests.
Friendly ping @caguero .
> Minor comments. Done.
> Not sure why the ABI checker doesn't catch it but I think that changing the access right (from private to public in our case) in `Discovery::AddRelayAddress()` breaks ABI. >...
> My main problem with this patch is that so far `NodeOptions` are all options that affect a single node. However, adding relays will have a global impact in all...
> > You're thinking something like the following? > > ``` > > class Node { > > // ... > > public: static void AddGlobalRelay(const std::string&); > > public:...
> I applied that fix but the original problem persists: > > ``` > [ 41%] Generating C++ type support for Protobuf > gmake[2]: /__w/rosidl_typesupport_protobuf/rosidl_typesupport_protobuf/ros_ws/install/rosidl_typesupport_protobuf_cpp/lib/rosidl_typesupport_protobuf_cpp/rosidl_typesupport_protobuf_cpp: Permission denied > gmake[2]: ***...