Marco Baumgartl

Results 14 comments of Marco Baumgartl

I was looking at changes needed to use custom cache backends in this library. I would like to make some changes to constructor interfaces to allow dependency inversion. pro -...

Hi @ankitpokhrel! I understand your concerns about introducing breaking changes. In general I want to move the architecture to use dependency inversion (it's impossible w/o breaking changes). In my opinion...

Hello @ankitpokhrel! I didn't have much time to work on this issue lately. Although I was unsure about how open you are to these changes. I'm glad to hear you...

> Is it possible achieve the same behavior without prototype modification? ```resetAttr``` was used inside the module only, so it's easy to replace: ```diff diff --git a/lib/setTableAttrs.js b/lib/setTableAttrs.js index 144056d..656191c...

You have to use the [url](https://github.com/jonkemp/inline-css#optionsurl) config property. ```js // import or require fs/promises + other modules const baseUrl = url.pathToFileURL(__dirname + path.sep).toString(); (async () => { const htmlFile =...

Any updates to this issue? We experience the error since yesterday. ```php [ "body":[ "upload" => [], "uri" => "/videos/xxx" ], "headers":[ "Accept-Ranges" => "bytes", "Cache-Control" => "private, no-store, no-cache",...

I think pegjs does this automatically (see [documentation](https://pegjs.org/documentation)) > The code inside an action can also invoke the error function, which also makes the parser throw an exception. The function...

The default implementation stores the upload urls using [Web Storage API](https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API) (when run in the browser). But you can implement an [interface](https://github.com/tus/tus-js-client/blob/master/docs/api.md#urlstorage) to share urls between browsers (e.g. by using...