Mauro Bieg

Results 270 comments of Mauro Bieg

> Could we set `isLightTheme` automatically by checking backgroundColor on the style? To determine whether we should inject the inverting CSS? Yeah, probably... we'd have to read out the style...

Okay, I've add a commit with that... seems to work. Even if it means that people have to use a custom template to set a different theme for dark mode....

Just a thought: could also have a custom prelude that just re-exports (a subset of) relude. Not sure this is a good idea though...

I'm not very familiar with AppImage intricacies. Do previous versions of PanWriter work?

Unfortunately, I had to disable this for Linux in https://github.com/mb21/panwriter/commit/7a0a9335b1d836b0a88fa524f936210b8b1d3a44 due to the Electron bug https://github.com/electron/electron/issues/21935 (see https://github.com/mb21/panwriter/issues/114#issuecomment-2226834675 for discussion)

Thanks for the reply! That clears things up. Yes, I later saw that sentence, it's somewhat hidden in the "New in v0.7.0+" box, which I skipped on first read, because...

Perhaps @andreamah could comment on whether this will be fixed in `findFiles2`? Or should I start working on a workaround for my extension? Thanks!

Indeed, the exact steps I reported above now seem to work on insiders.vscode.dev, yet I can still reproduce them on vscode.dev and github.dev (see [screen recording](https://github.com/user-attachments/assets/15170d27-5277-42df-9ba4-345f39935b9d)). Do you know what...

@osortega do I need to do anything for the `info-needed` tag to go away?

Okay, I debugged this with the Chrome dev tools on insiders.vscode.dev commit `7197360b79e6da3404ed5ad1fb4d7ea74a8bb5d2`: The return value of [this.provider.provideFileSearchResults](https://github.com/microsoft/vscode/blob/519df4f08646561bc1fc6b142dab9d80c1bf225c/src/vs/workbench/services/search/common/searchExtConversionTypes.ts#L460) does not include the new files. After that it calls into [this...