Mauro Bieg

Results 270 comments of Mauro Bieg

Okay, I've lightened up the background and overwrite the two darkest colors we have in the default pygments theme:

ah, but overwriting those two values would also overwrite them when the user specifies another theme... so reverted that part while keeping the slightly lighter background. if we're unhappy with...

True. But what about the reverse? Should the theme assume a light background and dark font? e.g. `pandoc --print-highlight-style pygments` gives: ``` "text-color": null, "background-color": null, ```

Anyway, I've added a `highlight-style-dark` option, which seems like the best solution anyway. I haven't really evaluated the different dark themes we have, is `breezeDark` the most neutral one? I...

> it would also need to be supported via defaults files ah yes, I assumed this would somehow get auto-generated from the command-line args... but I could add it... ---...

> Is it objectionable? I don't know.. the aggressive pink on black background certainly has a different feel to it than the default pygments theme in light mode... but I...

> Is there a way to do this in the CSS itself -- set the text-color in the Div to whatever the document's text-color is? probably... but we'd only want...

Ah, by not setting background-color on pre, and code at all, I actually got the invert approach working: https://github.com/jgm/pandoc/pull/7226

Update: that color-inverting approach (in the other PR) works okay with light themes (like the default pygments), but looks quite horrible in dark mode when applying a dark theme e.g....

> With the `--highlight-style-dark` approach, users who use dark mode will have bad results until they figure out that they need to specify this option. Not sure I understand this...