Michael Mayer
Michael Mayer
Looks great! Not sure about `xgb.shap.data()` as well. I don't think it is heavily used though. One comment: Why do we use ` .Call(XGSetArrayDimNamesInplace_R, arr, dim_names)` instead of a simple...
> @mayer79 That tutorial is outdated. Here is the new edition: https://adv-r.hadley.nz/functions.html According to that text, "replacement functions actually create a modified copy". Which shows that my comment was wrong!
> > The original code tried to rbind two data.frames with different column names. This is fixed. > > But is that what it was supposed to be doing? I...
Ha - do you have feature values that contain the substring `"_:_"`?
I will dig into it, thx for reporting.
Currently, I can reproduce only what is implemented: If feature values contain the string `"_:_"`, an internal function would fail. Thus, it yields an explicit error. ```r grid
Just for curiosity,: Did any variable contain values with a ":" in it?
I am using a logic almost 1:1 copied from R's `merge()` function to find row match indices over multiple columns. However, they use as column separater "\r", while I am...
@inkrement Would be fantastic if you could test your original (failing) example with the main branch `devtools::install_github("ModelOriented/hstats")`
Here the implementation in {treeshap}: https://github.com/ModelOriented/treeshap/blob/master/src/treeshap.cpp