xgboost icon indicating copy to clipboard operation
xgboost copied to clipboard

[R] Fix warning about mismatched names when joining

Open david-cortes opened this issue 1 year ago • 3 comments

fixes https://github.com/dmlc/xgboost/issues/10742 ref https://github.com/dmlc/xgboost/issues/9810

This PR fixes a warning (which actually turn out to come from data.table, not from DiagrammeR) about mismatched column names when concatenating inputs.

I'm not 100% if this is doing what the function is meant to do though, so would be ideal if someone could take a deeper look.

david-cortes avatar Aug 24 '24 16:08 david-cortes

@mayer79 Could you please help review this PR when you are available? I'm not familiar with the DiagrammeR package.

trivialfis avatar Aug 26 '24 17:08 trivialfis

The original code tried to rbind two data.frames with different column names. This is fixed.

But is that what it was supposed to be doing?

david-cortes avatar Aug 26 '24 19:08 david-cortes

The original code tried to rbind two data.frames with different column names. This is fixed.

But is that what it was supposed to be doing?

I think yes, but I have never actively used this function.

mayer79 avatar Aug 26 '24 19:08 mayer79