Max VelDink
Max VelDink
+1 for getting this fixed up. I would love to not maintain a fork for this functionality :)
Ran into this issue today. `cssbundling-rails` seems to not know about Yarn 4's Plug n Play default node linker. I changed this to the `node-modules` option and got this to...
Thanks @luizgribeiro ! @lukas-reining has a similar concern [here](https://github.com/open-feature/spec/pull/245#discussion_r1501681193), which I tried to alleviate by having the provider interface optionally implement the behavior. In contrast, the client interface always needs...
@luizgribeiro, I see what you're saying about the return type. I worry that we'd be adding too much complexity to the provider method if we introduced a new type to...
I believe I've addressed all feedback on this PR now. I'll wait until tomorrow morning and merge this if there is no other feedback!
> Hey @maxveldink, what's the motivation behind having the `type` in the data model? > > I think we might have a better chance of constraining the usage of this...
@toddbaert @dferber90 Yep, `description` could be returned in the `flag metadata` type that we have defined. That can largely be left up to the provider/underyling vendor
The current proposal seems to invite misuse, and we haven't reached an entire agreement. I'm cool with closing this attempt (with gratitude for the great conversation) so we can focus...
As mentioned above, closing for now. Thanks all for the conversation!
Yes, good catch!