maxtrevor
maxtrevor
Ok we need to get this merged in. I'm willing to do whatever needs to be done but not sure where to start. @dethodav @titodalcanton
> The first thing to solve is that this branch has developed a conflict with master, so a careful rebase is needed. The repo is under Derek's namespace. Would the...
@titodalcanton @dethodav whats next to keep this moving?
Requesting review from @titodalcanton and @spxiwh
Is this good to go?
@titodalcanton the only failure I can see in the test suite is this ``` 2022-09-22 17:00:12,409 PASS: GW170817 found with coherent SNR = 27.16; reweighted SNR 26.64 Pass. /home/runner/work/pycbc/pycbc ERROR:...
Ok but I'm not sure why that error is happening. The line ` if args.idq_channel ` should run fine shouldn't it? the whole point was to check whether an idq_channel...
Ah now I understand. I have those lines in my full branches for running the test analysis, but didn't include the add argument lines in this PR
The only check failing now is codeclimate. I am not sure how to address the 3 issues it has raised.
Tests are failing, it seems like they couldn't get files they needed for some reason? Its ntot something connected to my code. I previously passed all the non codeclimate checks...