Maxim Sharabayko
Maxim Sharabayko
The `srt-xtransmit` app has a PR adding multiple client connections to the `receive` and `generate` subcommand. Those is used for testing. You probably need to add this feature to the...
Still topical for the new receiver buffer. https://github.com/Haivision/srt/blob/09f35c0f1743e23f514cb41444504a7faeacf89e/srtcore/buffer_rcv.cpp#L621
Please add the following description: - What API changes are proposed? `srt_close_withreason`, `srt_close_getreason`, `enum SRT_CLOSE_REASON`, `SRT_CLOSE_INFO` - What protocol changes are proposed? - Why would not you reuse and extend...
## TODO - [ ] Rename "window" to "auto" as suggested by @ethouris - [x] Create a technical dept issue regarding getting rid of dynamic memory allocation #1279
A thread local object should be freed once the thread finishes its execution. Was SRT built with `-DENABLE_STDCXX_SYNC=ON` (C++11 thread objects) or `OFF` (POSIX)?
Better to use the latest version. The default on Linux machines is OFF (POSIX).
> Those packets, that are present in the member's receiver buffer and could be read, but were read from another member should not be included in the pktRcvDrop statistics. However,...
Statistics must be deterministic and precise, not dependent on the thread layout. The `rcvDropTooLateUpTo` may return two values: the number of skipped (existing but discarded) packets and the number of...
Valgrind likely does not like this `new` statement in the POSIX version of the thread-local error: https://github.com/Haivision/srt/blob/v1.5.2/srtcore/sync_posix.cpp#L484 However, the object is to be deleted by the [`ThreadSpecificKeyDestroy`](https://github.com/Haivision/srt/blob/v1.5.2/srtcore/sync_posix.cpp#L534) function passed into...
Just a note for possible reference in the future, the `rcvDropTooLateUpTo` also happens in `CGroup::recv(..)`, should be marked `WINKED` as well.