Maxim Sharabayko
Maxim Sharabayko
The current bandwidth estimation mechanism is intended for file transfer mode only. In particular, FileCC uses those estimates. Still, it should be noted the estimate might be quite inaccurate. In...
Once a protocol on the wire is being concerned, any change should be treated extremely carefully. In this case, BW estimation in live mode is not used by SRT itself,...
## Example Workflow Reporting Error Example Workflow to consider. Should we report an error to instruct a user to properly configure the pacing mode? ### Correct ```c++ srt_setsockflag(sockid, SRTO_INPUTBW, 80...
From the docs, `SRTO_MAXBW` binding: pre (must be set prior to calling `srt_connect()` or `srt_bind()` and never changed thereafter). `TEV_INIT_RESET` initialization event comes from two places: - a socket is...
Consider adjusting pacing mode names to be more distinguishable: - `SRT_PACING_DEFMAXBW` -> `SRT_PACING_MAXBWDFLT` - `SRT_PACING_MAXBW` -> `SRT_PACING_MAXBWSET` - `SRT_PACING_INPUTBW` -> `SRT_PACING_INPUTBWSET` - `SRT_PACING_ESTINPUTBW` -> `SRT_PACING_INPUTBWEST` - `SRT_PACING_HYBRIDBW` -> `SRT_PACING_INPUTBWADJ` ???
macOS builds are failing in Travis CI. ```shell error: unknown warning group '-Wambiguous-reversed-operator', ignored [-Werror,-Wunknown-warning-option] #pragma clang diagnostic ignored "-Wambiguous-reversed-operator" ```
Related epic #1813.
From your discussion, the only thing it can be hanging on is the `CRendezvousQueue:::m_RIDVectorLock` in `CRcvQueue::removeConnector(..)` , with the lock probably taken by `CRendezvousQueue::updateConnStatus(..)`. The [latest screenshot](https://github.com/Haivision/srt/issues/1952#issuecomment-821009314) seems to confirm...
It would be very surprising if it is hanging here, but just to check @BoleLiu could you please add some logs around `THREAD_PAUSED()` and `THREAD_RESUMED()`? ```c++ int CRcvQueue::recvfrom(int32_t id, CPacket&...
I see... 🤔 Could you please add more logs around `CRcvQueue::m_BufferLock` then? To track where it is hanging locked if it is the cause of the dead lock.