Max Philippov
Max Philippov
> Shouldn't you use React's `useCallback` for `onZoomOut`, `onZoomReset` and other such these functions? I don't think it helps and from what I know it might make things worse. useCallback...
> very nice! thanks a lot for iterating over in that area! > > some high-level comments: > > * the "-" icon looks wrong. it should have the same...
UPD: I've messed up DialogFooter layout, fixing it, not ready for merge
Okay, everything is fixed now. I've used FooterActions inside FooterActions for grouping different buttons together. I imply here that this is some kind of Actions group, but any feedback is...
> Better would be to reduce the rotation processing time of course... :-) Yeah, I'm finishing up the CSS-transform based version, it's instant now (except on saving which still goes...
So now everything should operate smoothly and pretty fast. The biggest JPG I've tested was 12Mb. This solution "projects" mouse position on "non-rotated" image and I kinda messed up the...
> however, i agree that RESET needs to reset everything, if we keep FLIP, that needs to be reset as well. > > that said, i would leave FLIP outside...
> * I still think the zoom behaviour is too slow, also it gets slower the further you are zoomed in. I agree on this one, but I don't know...
Rebased version is up, also fixed some bugs in RESET. `flipDirY` is still there because we operate on 'non-rotated' image so when it's rotated 90 or 270 degrees we use...
> the PR needs a rebase however. and i cannot say much to code-level things, open ends seem to be resolved, however. Someone juts took "let's get rid of all...