Max Philippov
Max Philippov
> > as i was asked: for the "X" button, indeed it would be a bit weird if it closes all dialogs if they are visually stacked. this is not...
> I can't do a review on the PR today(can't concentrate due to bad sleep pattern). But my opinion is mixed. You are doing BP removal which is desired but...
> I think we should forget about using Overlay for dialog and try to use the `` element that the browser already provides, it even already has a `::backdrop` css...
> Bugs from testing: Most of the dialog things should be fixed, but there's also a clear discrepancy between our styles. I didn't have a problem with flex dialog footer/header....
Rebased towards current main (to the monorepo version). Got some minor issues with colors, gonna look at these later and post here an update.
> @maxphilippov ist this final now for review? You mentioned on monday you will fix some issues? @Simon-Laux yeah, this is probably not ready to test yet, I had some...
So, that's my fault of not investigating enough. It introduces us to the world of 'top-layer', where there's no way to bypass dialogs other than Popover API, Fullscreen element, and...
> > I had to implement these using too > > What does this mean? > Shouldn't this be fixed by putting `FullscreenMedia` and `FullscreenAvatar` inside the dialog element? Yeah,...
> * [x] tabs are invisible in dark theme I've actually missed this one, gonna fix a bit later.
> operating systems and other programs do: they focus a dialog button on confirmation and alert dialogs. > > But that is not what we want for dialogs like fullscreenmedia...