maxomatic458

Results 28 comments of maxomatic458

I think thats actually pretty straight forward to implement Modrinth has [this](https://docs.modrinth.com/#tag/version-files) to get a mod from a sha1/sha512 hash and Curseforge has [this](https://docs.curseforge.com/#get-fingerprints-matches) to get a mod from a...

looks like something like that is actually already implemented https://github.com/Skidamek/AutoModpack/blob/e73aefad145be4156b10e545fda42e18afca00da/core/src/main/java/pl/skidam/automodpack_core/utils/Json.java#L92

you could probably save a few lines by changing it from ```rs // we'll check if start of span is greater than offset, to prevent panic // else we can...

you might be able to just this here ```rs let offset = offset.min(last.0.start).min(last.0.end); ``` ```rs let mut results = working_set .find_commands_by_predicate(filter_predicate, true) .into_iter() .map(move |x| SemanticSuggestion { suggestion: Suggestion {...

thats happening because the older playit versions are discontinued #56 fixes that

the same should be doable for curseforge the curseforge launcher is able to get a mods curseforge mod-id from the file (even if downloaded from another source) not sure if...

it should be doable via their api: https://docs.curseforge.com/?python#get-fingerprints-matches https://github.com/meza/curseforge-fingerprint

there is also https://curse.tools/, which doesnt require a key

just realized i used serde_json::Value, i think this might be what caused the panic. In my case i need to have a "any" type there so i will just wait...

hmm i think that might not be the cause of the problem here this also fails: ```rs #[derive(Debug, Clone, Serialize, Deserialize)] #[serde(rename = "AppState")] struct AppManifestFile { #[serde(rename = "appid")]...