Maximilian Linhoff comments

Results 344 comments of


                                            Maximilian Linhoff

tox4: UnicodeDecodeError on line 100 of execute/stream.py

Shouldn't the `"utf-8"` just be replaced with `sys.getdefaultencoding()`?

tox4: UnicodeDecodeError on line 100 of execute/stream.py

If the encoding is known, `SyncWrite` should get it it `__init__` as an argument and use that and at the point where you create the `SyncWrite` you pass the correct...

tox4: UnicodeDecodeError on line 100 of execute/stream.py

Using chardet is only a last resort. You should be able to *know* the encoding of the stream you are working on.

tox4: UnicodeDecodeError on line 100 of execute/stream.py

This can be fixed by encluding ``` setenv = PYTHONIOENCODING=utf-8 ``` for the envs in `tox.ini`

`sphinx-build clean` does not clean generated docs by automodapi

That's what I am doing now, the question was if this could be somehow automatized by the plugin so that the standard makefile "just works"

`sphinx-build clean` does not clean generated docs by automodapi

How does the theme address auto generated docs?

`sphinx-build clean` does not clean generated docs by automodapi

Isn't autogenerating docs pages orthogonal to how the theme makes it look?

Validate frame attributes when setting them, not when getting them

Yes, I still think this is a good idea, however I cannot promise when I can get back to it

Performance of Angle, Latitude and Longitude is a major bottleneck in coordinate transforms

We need both. We have coordinate trafos in event wise processing that have other constraints that prevent bunching them into large arrays. In later stages of processing, we then deal...

Performance of Angle, Latitude and Longitude is a major bottleneck in coordinate transforms

I guess so, and I guess that internally in astropy there are many places where you can rely on something already being validated. But that would require mich more investigation...