Maxime Biais comments

Results 61 comments of


                                            Maxime Biais

Create a "Search button" in the WC activity action bar

see #26

Integrate ReactNativeAztec into RecyclerViewList

I'm not sure about that one, we should keep these libraries independent and we will "test" this configuration in `gutenberg-mobile` anyway.

Crash report wpandroid: SQLiteException in TracksDatabaseHelper.getReadableDb

Not sure we can fix this without forking `SQLiteOpenHelper`.

ViewRootImpl$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.

Thanks @thomashorta for investigating, yeah I think having `onSuccess` and `onError` running on the main Android thread is best, I'll fix it in a 0.2.1 release of gravatar.

Documentation: store and use an API key

We should also write a bit of documentation for the backend side of things: - create a developer account - get the API key

Documentation: "Getting Started" page

- [ ] override the theme to change colors and text style

Replace `enum class ErrorType` by a sealed class to add properties to errors

Hey @eyedol sorry, I missed your previous comment. This one is a bit tricky as we don't know yet what property we'll add. Same as with #66 this is going...

`Could not find com.github.yalantis:ucrop:2.2.8.`

version 2.2.9 was shipped a few days ago but not published to maven central.

API: `uploadImage` (and future private endpoints) onError callback should encapsulate the error message returned from the backend

Hey @eyedol, thank you for looking into that. We'll need to update the backend first to add a new error code field. Currently there is no error code and we...

Listen for changes in the profile image?

WP Android uses different image views to show profile pictures depending on the views (login, comment, notifications, etc.) and it also uses [its own image cache](https://github.com/wordpress-mobile/WordPress-Android/blob/ac56c495d4f5cecf2a50f349576f23515679d8b1/WordPress/src/main/java/org/wordpress/android/util/BitmapLruCache.java#L11), I think other cache...