Gravatar-SDK-Android icon indicating copy to clipboard operation
Gravatar-SDK-Android copied to clipboard
verified publisher icon Automattic

Replace `enum class ErrorType` by a sealed class to add properties to errors

Open maxme opened this issue 1 year ago • 4 comments

maxme avatar Jan 16 '24 07:01 maxme

@maxme is this up for grabs if so will be nice to flesh out a bit more or this sort of depends on the work needed by backend for #66 ?

eyedol avatar Apr 03 '24 15:04 eyedol

oh I was hoping to receive a response on it. If it's not ready then I'll wait.

eyedol avatar Apr 10 '24 20:04 eyedol

Hey @eyedol sorry, I missed your previous comment. This one is a bit tricky as we don't know yet what property we'll add. Same as with #66 this is going to depend on the API changes. This ticket serves more of a reminder than a real task for now.

maxme avatar Apr 11 '24 06:04 maxme

No worries. This is also not ready then. Thanks for confirming it.

eyedol avatar Apr 11 '24 15:04 eyedol

@maxme Given that we will release a major version, do you think we should also tackle this one?

AdamGrzybkowski avatar Sep 17 '24 10:09 AdamGrzybkowski