maxlem

Results 9 comments of maxlem

Hello! Thanks for the review. I tried to touch the driver side as little as possible. I agree it is not perfect as it is. I think it could work...

so @runger1101001 You want me to move the SPI/Sensor stuff to the drivers repository? The thing is, SPIClass is barely usable with other sercoms than sercom4 with the state of...

All good points! Personally, I don't like this _apiFunction() with global variables hidden in cpp files. We should use OO instead. If you fear for virtual table lookups, we can...

Hi, was not able to extract the .hex files, would you please share them with me also, I'd like to point you out to the oscope 2100 project that I...

I'm willing to port the defines to the other samd variant.cpp

Yes we might just as well not neclare them, I was just shooting for the most minimal changes. The use case would me to add -D ARDUINO_ZERO_CUSTOM_SERCOM0_SERIAL to the build...

> if only the handler is disabled but not the object, then you'd end up with a non-functioning serial object Yeah that's true, I though so after my comment So...

oh, I must have missed that part, so the other idea would *imply* that the instances and definitions are retired from variant.cpp. Then that fixes my issue

Well, I'm all in support of the idea, but this is way out my time budget for now, so I went on and created this [PR](https://github.com/arduino/ArduinoCore-samd/pull/632)