Max Lord comments

Results 8 comments of


                                            Max Lord

[JS] @genkit-ai/dotprompt package is not ESM compatible

This error is the error you get when you call `definePrompt` but the `dotprompt` plugin has not been installed. I tried building the dotprompt extension as an ESM module and...

[JS] @genkit-ai/dotprompt package is not ESM compatible

Resolved in 952b3054

[FR] Add prompt name to the trace fields

I believe the appropriate solution to this is to modify the dotprompt plugin so that it calls its defined prompt action when it renders the prompt. This should create a...

[FR] Add prompt name to the trace fields

It would be the same action. Are we not writing those traces or not retrieving them? That might be a problem.

[FR] Add prompt name to the trace fields

Ok right, the filter only affects `LocalFileTraceStore`. This is more about production observability, so I think it's still the right approach.

[FR] Add prompt name to the trace fields

Addressed in this PR https://github.com/firebase/genkit/pull/785 Using the action proved to be problematic for a number of reasons. I think the most straightforward approach is for dotprompt to create its own...

[JS] dotprompt `.generate` and `.render` methods don't allow custom config options

I looked into this a bit. It's not possible to identify the correct custom options type if we accept string model arguments, so it should be `any` in that case....

Schnecle/crashlytics resources exploration

Absorbed into PR 9594