Sam Lin

Results 69 issues of Sam Lin

Hi , I think some developer like me would like to use font icon instead of base64 embedded icon. I wonder if you want to go that way. To achieve...

enhancement

It should check if there is an existing secret here https://github.com/cowboysysop/charts/blob/edddb59248c658f407e355335026655d365e5283/charts/lighthouse-ci/templates/deployment.yaml#L57

first of all, thank you for creating this. When it is on "create pull request" step, I got an error like `Error: Review cannot be requested from pull request author.`...

**Describe the solution you'd like** It would be nice to have an option to create a backup before changing And Thank for your awesome work!

I wonder if it is hard to put it here https://jmeter-plugins.org/

enhancement

I tried something like ```json { file: 'file.scss', all: true } ``` And it doesn't work. Anyway, it is a great project. Thanks!

question

**Describe the bug** Connection closed to api/v1/stream/events/argo-workflows?listOptions.fieldSelector=involvedObject.kind=EventSources,involvedObject.name=webhook **To Reproduce** 1. Enable SSO.RBAC 2. Create a webhook event source as the example from the doc **Expected behavior** Should be able to...

bug

### Describe the bug if serviceAccount.create is false at https://github.com/argoproj/argo-helm/blob/db0957d3cbae617b72995ee3db8790081f2095ef/charts/argo-workflows/values.yaml#L34 It will still try to bind the serviceAccount.name at https://github.com/argoproj/argo-helm/blob/db0957d3cbae617b72995ee3db8790081f2095ef/charts/argo-workflows/templates/controller/workflow-rb.yaml#L19 I think at https://github.com/argoproj/argo-helm/blob/db0957d3cbae617b72995ee3db8790081f2095ef/charts/argo-workflows/values.yaml#L38 we should set it as default...

bug
argo-workflows

First of all, thanks for the amazing project. I wonder if you are interested in having another admin for this project or if you have time to take care some...

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Based on above link, we need to update this https://github.com/fjogeleit/yaml-update-action/blob/1b05b4490e1fdeea39cb42d2ba7c621c94fd5088/package.json#L28