argo-helm icon indicating copy to clipboard operation
argo-helm copied to clipboard

Service Account in Argo Workflow

Open maxisam opened this issue 3 years ago • 0 comments

Describe the bug

if serviceAccount.create is false at https://github.com/argoproj/argo-helm/blob/db0957d3cbae617b72995ee3db8790081f2095ef/charts/argo-workflows/values.yaml#L34

It will still try to bind the serviceAccount.name at https://github.com/argoproj/argo-helm/blob/db0957d3cbae617b72995ee3db8790081f2095ef/charts/argo-workflows/templates/controller/workflow-rb.yaml#L19

I think at https://github.com/argoproj/argo-helm/blob/db0957d3cbae617b72995ee3db8790081f2095ef/charts/argo-workflows/values.yaml#L38 we should set it as default or use something like

https://github.com/argoproj/argo-helm/blob/db0957d3cbae617b72995ee3db8790081f2095ef/charts/argo-workflows/templates/_helpers.tpl#L82-L91

to avoid unexpected issue.

Related helm chart

argo-workflows

Helm chart version

0.17.1

To Reproduce

rbac is incorrect with the default values.yml

Expected behavior

rbac should bind correctly

Screenshots

No response

Additional context

No response

maxisam avatar Sep 06 '22 15:09 maxisam