Maxime Mulder

Results 17 comments of Maxime Mulder

This was discussed in today's (2024-04-23) meeting, everyone agrees it would make more sense to make this field nullable instead of using an empty string.

I must say I am not sure what I am supposed to do regarding the failed tests on files that I did not modify in the PR. Any direction @driusan...

Hum, yeah, I already saw that. I was just suprised to see that the errors are marked as originating from `FilesDownloadHandler.php` and `SiteIDGenerator.php`, which are not modified by this PR....

I've looked at the static errors in more details, it appears to be mainly due to an upgrade of phpstan, which changes the typing of string conversions with `strval` and...

Ok it seems the linting errors are ~~fixed~~, silenced. @laemtl had noticed that the errors were due to a composer update on my end. The errors should still appear in...

@ridz1208 Ok I finally finished updating and re-testing this PR. Generally it seems to work. However, if the pipeline fails during the latter stages, the DICOM archive previously inserted does...

I replied to all the comments and applied the suggested changes. I reverted the breaking changes to the API including floats / strings and naming. Back when I wrote them,...