Maxime Mulder

Results 17 comments of Maxime Mulder

I just noticed that I did this PR quite some time ago and wasn't aware of the testing plan at the time, gonna add it before merging.

I did not comply to all the lints yet because I think some would decrease the quality of the code. So I'll discuss that before doing anything else. It is...

Sorry for the wait, I agree there is a lot of code to review. However, it is mostly a "dumb" port of the module front-end to a more modern stack...

I believe the tests will pass once the linked PR is merged. EDIT: It did 🥳

As per the last meeting, I added @ridz1208 as a reviewer. Just tell me what you think of this idea of a refacor. If you like it, I'll rebase it,...

Closin in favor of #9101, which is going to be more descriptive.

Ahok, thanks for finding that. I briefly had this issue during my testing but it disappeared and I did not manage to find back the reproduction conditions so I kind...

I tried to change the query to emulate the behaviour of the imaging browser table, but I am advancing very slowly as there are too many things I don't know...

To be honest, I mostly opened this issue with the idea of fully modernizing the header in the future rather than just fixing the style. The current code is very...

@driusan Agree with both suggestions. While we are on the subject of naming, do you have any opinion on `FooElement` vs `FooInput` ? I used the first one to be...