Maxime

I really don't have any substantial amount of time to put into `ngx-sub-form` I'm afraid. Offering ideas and making reviews is probably the best I can do for the time...

Hi @temka1234 :wave: not sure how I feel about this. I believe in most cases we would want this and having some type safety forcing us implementing it is IMO...

There's also something that is worrying me, but I got lazy and didn't want to search for it as I couldn't remember where I came across that :sweat_smile:. So thanks...

@noobyogi0010 wow sorry for the delay here, I completely forgot about this thread, just found it randomly :exploding_head:. We recently merged the rewrite so that's a good timing. If you're...

> rebased locally and force pushed. @maxime1992 did something go weird with your git setup or workflow? Not sure why these MR's are only giving the option to `Rebase and...

discussed offline with @zakhenry: - can't really do a `oneOf` pattern without ngx sub form anyway :shrug: - easy to make a breaking change later on if we move that...

Hi @codehunter13 :wave: What you said is correct :heavy_check_mark: When using the `NgxAutomaticRootFormComponent` we do the following check: https://github.com/cloudnc/ngx-sub-form/blob/master/projects/ngx-sub-form/src/lib/ngx-automatic-root-form.component.ts#L18 And when using `NgxRootFormComponent` we do the following check: https://github.com/cloudnc/ngx-sub-form/blob/master/projects/ngx-sub-form/src/lib/ngx-root-form.component.ts#L98 If...

Hello :wave: There's one problem I can think of and have no idea how to go around: While it'd work fine on the root level because it'd be as easy...

Thanks for sharing your POV. On > In my opinion, the subforms do not need to be changed. I think it may be quite confusing to have an event on...

@zakhenry regular validation doesn't apply any kind of type checking. Therefore, if you forget to apply a required somewhere chances are it'll trigger bugs upstream (trying to access a property...