ngx-sub-form icon indicating copy to clipboard operation
ngx-sub-form copied to clipboard
verified publisher icon cloudnc

feat: remove deprecated inheritance API

Open maxime1992 opened this issue 3 years ago • 2 comments

~~:warning: Review after https://github.com/cloudnc/ngx-sub-form/pull/259 is merged :warning:~~

:heavy_check_mark:

maxime1992 avatar Jun 10 '22 13:06 maxime1992

rebased locally and force pushed. @maxime1992 did something go weird with your git setup or workflow? Not sure why these MR's are only giving the option to Rebase and merge? It's messing with subsequent merge requests because they don't get the correct history and have to be rebased manually because of conflicts.

We should just do merge commits IMO, it is a true record of the history

zakhenry avatar Jun 13 '22 04:06 zakhenry

rebased locally and force pushed. @maxime1992 did something go weird with your git setup or workflow? Not sure why these MR's are only giving the option to Rebase and merge? It's messing with subsequent merge requests because they don't get the correct history and have to be rebased manually because of conflicts.

We should just do merge commits IMO, it is a true record of the history

We had this in the settings:

image

I've turned it off

maxime1992 avatar Jun 13 '22 06:06 maxime1992