Marshall Bowers

Results 367 comments of Marshall Bowers

@k0tran It looks like in this version the code to remove older language servers was removed: https://github.com/k0tran/zed_neocmake/compare/7cab1dd03e0f5055f253571778c571004aed0f4d...376321432a945fcd91c5aac008ff1b26fa9dcf29#diff-7a58343a9453f7caca008e4a9375027a58151234c9537ed79f44078fcb824343L74-L81 Was there a particular reason for this?

> > Was there a particular reason for this? > > When I first saw this code I thought it is for removing everything except lsp binary in the archive....

Closing due to inactivity. Feel free to reopen or open a new PR if you pick this back up.

> so I suspect this failed because of this line in the workflow file: https://github.com/zed-industries/extensions/actions/runs/10411662361/workflow?pr=1253#L68 > > I'm not really familiar with Github's CI, so I'm guessing here > >...

@xhyrom Before we go accepting this into the registry, could you say a bit more about how the Discord auth works for the Discord rich presence language server?

> > @xhyrom Before we go accepting this into the registry, could you say a bit more about how the Discord auth works for the Discord rich presence language server?...

@xhyrom Could you change the extension ID to be `discord-presence` instead of `discord_presence`? We don't allow underscores in extension IDs.

> > @xhyrom Could you change the extension ID to be `discord-presence` instead of `discord_presence`? We don't allow underscores in extension IDs. > > fixed Can you update here as...

> done :D @xhyrom I think we're almost there! Looks like the two version numbers don't align right now.

The function used to download the language server assets is agnostic to any form of hosting service: https://docs.rs/zed_extension_api/latest/zed_extension_api/fn.download_file.html In v0.1.0 of the `zed_extension_api` we now ship a generic HTTP client...