extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Add fennel language/grammar support

Open mattly opened this issue 1 year ago • 4 comments

Does not currently support the LSP, because AFAICT Zed only supports LSPs hosted on Github

mattly avatar Aug 15 '24 22:08 mattly

We require contributors to sign our Contributor License Agreement, and we don't have @mattly on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Aug 15 '24 22:08 cla-bot[bot]

@cla-bot check

mattly avatar Aug 15 '24 22:08 mattly

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Aug 15 '24 22:08 cla-bot[bot]

so I suspect this failed because of this line in the workflow file: https://github.com/zed-industries/extensions/actions/runs/10411662361/workflow?pr=1253#L68

I'm not really familiar with Github's CI, so I'm guessing here

And it's failing because my repository is not hosted on Github.

So, I could mirror it here, but the fennel community is taking more of an older-school OSS approach to how they distribute and work on things; while the language has a copy of the repository here, most development takes place on SourceHut, including the good language server.

I suspect a lot of the decisions lashing Zed to Github for things were probably made in a expedient "it's easy and solves most problems" manner, but if it is going to become a truly "open" editor, it needs to support extensibility uses that involve resources hosted elsewhere.

mattly avatar Aug 16 '24 17:08 mattly

so I suspect this failed because of this line in the workflow file: https://github.com/zed-industries/extensions/actions/runs/10411662361/workflow?pr=1253#L68

I'm not really familiar with Github's CI, so I'm guessing here

And it's failing because my repository is not hosted on Github.

So, I could mirror it here, but the fennel community is taking more of an older-school OSS approach to how they distribute and work on things; while the language has a copy of the repository here, most development takes place on SourceHut, including the good language server.

I suspect a lot of the decisions lashing Zed to Github for things were probably made in a expedient "it's easy and solves most problems" manner, but if it is going to become a truly "open" editor, it needs to support extensibility uses that involve resources hosted elsewhere.

It's actually failing because there is a typo in the extensions.toml file: https://github.com/zed-industries/extensions/pull/1253/files#diff-724e5177a66640ebdc9d051879ac354bbfd595c1b4d039bab887600964bb2023R312

maxdeviant avatar Aug 23 '24 01:08 maxdeviant