maxberger

Results 30 comments of maxberger

I've just added support for mine (4 inch, two color): https://github.com/BenRoe/rpi-magicmirror-eink/pull/3 Which display are you using? If you send me which one then I can try to add yours as...

Adding the second color to the library is quite easy. The existing code provides support for adding an image for every color. The (hard) part is detecting which parts of...

Sorry for the late reply, my life kept me busy. I am now back and trying to get this into good shape. I do see a strong push for consistency...

Like the idea; added this to the extension as well.

> in general a good topic! I'm not convinced yet on the implementation. E.g. the long lasting tasks are not cancelled but some fast/short loops are. > > The read...

> thx! see comment / question regarding usage of deferred cancelation type. In general I'd prefer: > > * change to default deferred cancellation > * check code / loops...

> @maxberger: sadly no debian packaging experts on our team. could you also have a look at [volkszaehler/libsml#97](https://github.com/volkszaehler/libsml/pull/97) ? Unfortunately I am not a debian expert, so I am not...

While I totally agree that rewriting the .service file to use foreground makes sense, I really just took the example file from the main directory and copied it to debian/...

For the mocketermap error see pr #528

Updated, please review again. Tests fail currently due to unrelated issues, I will create another pull request for those.