Max Veit

Results 50 comments of Max Veit

Here is the error message from compiling `kvec_generator.cc` with Eigen 3.4, in case anyone likes inspecting runes: ``` In function ‘__m256d _mm256_loadu_pd(const double*)’, inlined from ‘Packet Eigen::internal::ploadu(const typename unpacket_traits::type*) [with...

Update, now this seems to happen with Eigen 3.3 as well... I don't know what to do other than exclude `kvec_generator.cc` from the build.

"got better"... well, that's debatable, depends on your definition of "better". I've checked the affected section of code several times and still don't understand where a potential out-of-bounds assignment would...

Very good, thanks for adding this! I probably won't have time for a full review anytime soon (maybe late next week but no promises). But right now my main comment...

This is good; how about moving the solvers into their own function (taking just the matrices K_NM, K_MM, and Y), separate from the setup/manager/saving logic implemented in `train_gap_model`?

Btw, merging with the main branch will now fix two out of the three test failures. The remaining failure is due to unit test coverage, which I suggest we do...

Just found #260 , which is related because this issue could also have been found with clearer code.

Sure, just commit your fix to a branch named like `bugfix/sc_num_coefficients`.

It's in `bindings/rascal/representations/spherical_covariants.py`, where SphericalCovariants is defined.

> Another alternative is `lascar`, almost reversed =) https://pypi.org/project/verlanize/ ? Might be an option for coming up with new package names in the future, provided we start with something that's...